Nouns Builder contest - dic0de's results

A permissionless, governed protocol to deploy nouns-style DAOs complete with treasury, generative collections, and governance mechanisms.

General Information

Platform: Code4rena

Start Date: 06/09/2022

Pot Size: $90,000 USDC

Total HM: 33

Participants: 168

Period: 9 days

Judge: GalloDaSballo

Total Solo HM: 10

Id: 157

League: ETH

Nouns Builder

Findings Distribution

Researcher Performance

Rank: 141/168

Findings: 1

Award: $60.77

🌟 Selected for report: 0

🚀 Solo Findings: 0

Overview

registerUpgrade () and removeUpgrade () functions does not check if the implementation is registered before registering or removing upgrade. This is visible here https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/manager/Manager.sol#L187-L200.

Impact

  1. It allows for re-registration of upgrades where already registered upgrades are again registered.
  2. It also allows for removal of upgrades which are not even registered.

Recommendation

  1. Consider checking if the upgrades are registered before registering or removing upgrades.

#0 - GalloDaSballo

2022-09-26T21:28:36Z

NC

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter