Platform: Code4rena
Start Date: 27/04/2022
Pot Size: $50,000 MIM
Total HM: 6
Participants: 59
Period: 5 days
Judge: 0xean
Id: 113
League: ETH
Rank: 37/59
Findings: 1
Award: $74.49
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1337, 0x1f8b, 0xDjango, 0xf15ers, AuditsAreUS, BowTiedWardens, CertoraInc, Funen, GimelSec, MaratCerby, Ruhum, WatchPug, antonttc, berndartmueller, bobi, bobirichman, broccolirob, catchup, cccz, defsec, delfin454000, gs8nrv, gzeon, horsefacts, hubble, hyh, ilan, jah, joestakey, kebabsec, kenta, kenzo, m9800, mics, oyc_109, pauliax, reassor, robee, samruna, sikorico, simon135, throttle, unforgiven, z3s
74.4906 MIM - $74.49
Division causes ceiling and therefore loss of precision. In the other hand multiplication does not. In the following situations you can rearange the equation to use multiplication instead of division.
The fee parameter need to be validated since otherwise you may allow it to be 0 fee. And fee that is over 100% for example is also probably a mistake that can happen with the decimals.
#0 - cryptolyndon
2022-05-13T03:06:50Z
EDIT The "fee over 100%" comment, that has nothing to do with the lines, reappears in #123. Suspect this person is trying to cheat. See #124