AbraNFT contest - jah's results

A peer to peer lending platform, using NFTs as collateral.

General Information

Platform: Code4rena

Start Date: 27/04/2022

Pot Size: $50,000 MIM

Total HM: 6

Participants: 59

Period: 5 days

Judge: 0xean

Id: 113

League: ETH

Abracadabra Money

Findings Distribution

Researcher Performance

Rank: 44/59

Findings: 1

Award: $72.42

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

72.4178 MIM - $72.42

Labels

bug
duplicate
QA (Quality Assurance)

External Links

Lines of code

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol

Vulnerability details

Impact

The NFTPair.sol uses transferFrom to transfer ERC721 after repaying or removing collateral so if a user isn't aware of the incoming ERC721 token the NFT can get locked forever

Proof of Concept

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L266 https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L266

Tools Used

Manual

use safeTransferFrom

#0 - cryptolyndon

2022-05-05T21:25:43Z

Duplicate of #20

#1 - 0xean

2022-05-21T15:10:13Z

see #20 - downgrading to QA

#2 - JeeberC4

2022-05-23T19:03:19Z

Preserving original title: use of transferFrom

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter