Platform: Code4rena
Start Date: 27/04/2022
Pot Size: $50,000 MIM
Total HM: 6
Participants: 59
Period: 5 days
Judge: 0xean
Id: 113
League: ETH
Rank: 39/59
Findings: 1
Award: $73.06
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1337, 0x1f8b, 0xDjango, 0xf15ers, AuditsAreUS, BowTiedWardens, CertoraInc, Funen, GimelSec, MaratCerby, Ruhum, WatchPug, antonttc, berndartmueller, bobi, bobirichman, broccolirob, catchup, cccz, defsec, delfin454000, gs8nrv, gzeon, horsefacts, hubble, hyh, ilan, jah, joestakey, kebabsec, kenta, kenzo, m9800, mics, oyc_109, pauliax, reassor, robee, samruna, sikorico, simon135, throttle, unforgiven, z3s
73.0579 MIM - $73.06
[N01] Leap-years considerations
for more precision and considering leap years you could take a year as 365.25 for more precision.
[N02] inconsistent checking of address(0) for collateral and asset contracts
you should check both, collateral and asset or none for more consistency
[N03] use enums for better readability
#0 - cryptolyndon
2022-05-13T05:50:34Z
Seen, thanks.
[N02] checking neither would break things spectacularly; the check has a different purpose